How should i forgive myself and for how long should my punishment be for having an affair?

Sounds like you are completely unhappy. Just because you enjoyed having someone being nice to you does not constitute an affair. You may need to seek some marriage concealing maybe he will understand your needs, but it seems doubtful. If not get a divorce, move on with your life, and find someone that will.